Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(renderer): remove the replacement 'div' for ConfigProvider when i… #3022

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

AndyJinSS
Copy link
Contributor

当renderer中的ConfigProvider未设置时默认以div进行兜底,但这样做的坏处就是div会影响布局,当我们以flex布局整个应用时,div不会继承高度,会导致内部的flex布局组件因为缺少高度失效。
建议当ConfigProvider为空时不创建元素,ConfigProvider可以由上层封装自主实现,因为不同的组件库ConfigProvider的属性是不一样的,目前也仅传入了device和locale,所以面向pc和移动端不同的组件库当前方案实际上也无法满足需求,不设置renderer的ConfigProvider这种场景是存在的。

@woshilaoge
Copy link
Collaborator

再试试,拉取下 develop 分支最新代码

@1ncounter 1ncounter merged commit 6950329 into alibaba:develop Jul 3, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants